Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-425 Disable ServerLogTest until Grizzly upgrade #4872

Merged
merged 1 commit into from
Sep 4, 2020
Merged

FISH-425 Disable ServerLogTest until Grizzly upgrade #4872

merged 1 commit into from
Sep 4, 2020

Conversation

MattGill98
Copy link
Contributor

Will otherwise fail until Grizzly is upgraded

@MattGill98 MattGill98 self-assigned this Sep 4, 2020
MarkWareham
MarkWareham approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@MarkWareham MarkWareham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference would be to provide reference in ignore comment, but doesn't warrant requesting changes

@dmatej
Copy link
Contributor

dmatej commented Sep 4, 2020

I added link to this PR to a description of the QACI-406 so I will revert that with the upgrade.

@MarkWareham MarkWareham merged commit ee70114 into payara:master Sep 4, 2020
@MattGill98 MattGill98 changed the title Disable ServerLogTest until Grizzly upgrade FISH-425 Disable ServerLogTest until Grizzly upgrade Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkWareham MarkWareham MarkWareham approved these changes

@jGauravGupta jGauravGupta jGauravGupta approved these changes

Assignees

@MattGill98 MattGill98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattGill98 @dmatej @jGauravGupta @MarkWareham