FISH-37 URL in DataSourceDefinition overrides serverName #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If URL has been set it should override the serverName, causing that to be set to null to prevent that being using when the DataSource is initialised Fixes payara#4385
Pandrex247
requested changes
Sep 4, 2020
...va/org/glassfish/jdbcruntime/deployment/annotation/handlers/DataSourceDefinitionHandler.java
Show resolved
Hide resolved
Pandrex247
approved these changes
Sep 4, 2020
|
jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix.
If URL has been set it should override the serverName, causing that to be set to null
to prevent that being using when the DataSource is initialised
Fixes #4385
Important Info
Testing
New tests
New test added in PR, DataSource Definition Tests
Testing Performed
Testing Environment
Zulu JDK 1.8_262 on Ubuntu 20.04 with Maven 3.6.3