Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-391 OutOfMemoryError exception caused by OpenApi refactor #4865

Merged
merged 21 commits into from
Sep 5, 2020
Merged

FISH-391 OutOfMemoryError exception caused by OpenApi refactor #4865

merged 21 commits into from
Sep 5, 2020

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Aug 31, 2020

Signed-off-by: Gaurav Gupta [email protected]

Description

This is a fix to discard HK2 types info after OpenAPI document creation. And with this fix, OpenAPI document creation is now performed after deployment of the application in a separate thread.

Testing

Microprofile OpenAPI TCK
Microprofile Fault-Tolerance TCK

@jGauravGupta
Copy link
Contributor Author

jenkins test please

Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What does the testing hang on?

@AlanRoth
Copy link

AlanRoth commented Sep 1, 2020

LGTM. What does the testing hang on?

The beginning of Fault Tolerance. We've had the issue of FT hanging for maybe couple hours before, never a complete hang though

@jGauravGupta
Copy link
Contributor Author

Both Microprofile OpenAPI and Fault-Tolerance TCK passed.

@Pandrex247
Copy link
Member

Jenkins test please

@MarkWareham
Copy link
Contributor

jenkins test please

MattGill98 and others added 4 commits September 2, 2020 15:01
This reverts commit 2a0b89b.

The reverted commit breaks a websocket TCK test. QACI-406 will endeavour
to fix this test without rolling back functionality.
@jGauravGupta
Copy link
Contributor Author

Jenkins test please

1 similar comment
@jGauravGupta
Copy link
Contributor Author

Jenkins test please

Pandrex247 and others added 2 commits September 4, 2020 09:13
Revert "FISH-31 Upgrade Grizzly to 2.4.4.payara-p3"
@MattGill98
Copy link
Contributor

jenkins test please

@MattGill98
Copy link
Contributor

@MarkWareham @Pandrex247 @jGauravGupta

My understanding is that this branch currently contains the OpenAPI fix, the Grizzly revert and the ServerLogTest disable. With these 3 it should pass the tests - is that about right?

@jGauravGupta
Copy link
Contributor Author

Yes @MattGill98 , You are right this PR contains all 3 mentioned changes.

@MattGill98

This comment has been minimized.

1 similar comment
@MattGill98

This comment has been minimized.

@jGauravGupta
Copy link
Contributor Author

jenkins test please

@jGauravGupta jGauravGupta merged commit b91a7b4 into payara:master Sep 5, 2020
Cousjava pushed a commit to Cousjava/Payara that referenced this pull request Jan 27, 2021
FISH-391 OutOfMemoryError exception caused by OpenApi refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants