FISH-477 Deployment group properties are now resolved #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Pandrex247
reviewed
Sep 3, 2020
| // so we need to add System Properties in *reverse order* to get the | ||
| // right precedence. | ||
|
|
||
| List<SystemProperty> domainSPList = domain.getSystemProperty(); | ||
| List<SystemProperty> configSPList = getConfigSystemProperties(); | ||
| Cluster cluster = server.getCluster(); | ||
| List<SystemProperty> clusterSPList = null; | ||
|
|
||
| List<DeploymentGroup> depGroups = server.getDeploymentGroup(); |
There was a problem hiding this comment.
Can this be null?
Having trouble reproducing atm
There was a problem hiding this comment.
This cannot be null, but the list may be of length 0.
There was a problem hiding this comment.
This cannot be null, but is can be a 0-sized list.
|
Jenkins test please |
Pandrex247
requested changes
Sep 7, 2020
Cousjava
changed the title
Cousjava
force-pushed
the
FISh-275-deploymentgroup-properties
branch
from
4d25834 to
745ed3a
Compare
Pandrex247
approved these changes
Sep 28, 2020
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix
Important Info
Blockers
Testing
Testing Performed
Manual tests, see Jira for reproducer
Testing Environment
Zulu JDK 1.8_212 on Ubuntu 20.04 with Maven 3.6.3