Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-256 Identify, Transform, and Run jakarta.* application #4813

Merged
merged 7 commits into from
Aug 21, 2020
Merged

FISH-256 Identify, Transform, and Run jakarta.* application #4813

merged 7 commits into from
Aug 21, 2020

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Aug 3, 2020

Signed-off-by: Gaurav Gupta [email protected]

Description

This is a feature to detect Jakarta EE 9 application and transform jakarta.* namespace to javax.* namespace then perform the usual deployment operation.

Depends on PR

payara/transformer#1
payara/Payara_PatchedProjects#320

Testing

Testing Performed

Tested manually deployment of WAR module (.war), EAR module (.ear), EJB Module (.jar)

New Tests

public void testNamespace() throws Exception {
jakarta.ws.rs.Path jakartaPathAnnotation = HelloWorldController.class.getAnnotation(jakarta.ws.rs.Path.class);
try (WebClient webClient = new WebClient()) {
TextPage page = webClient.getPage(base + "/api/hello");
assertTrue("Status code", page.getWebResponse().getStatusCode() == 200);
assertNotNull("Existing Annotation", jakartaPathAnnotation);
assertNotNull("Existing Annotation Value", jakartaPathAnnotation.value().equals("/api/hello"));
assertTrue("Transformed Annotation", page.getContent().contains("javax.ws.rs.Path"));
}
}

Documentation

payara/Payara-Community-Documentation#52

@jGauravGupta jGauravGupta requested a review from Pandrex247 August 3, 2020 11:03
@jGauravGupta jGauravGupta changed the title FISH-256 Identify, Transform, and Run Application jakarta.* application FISH-256 Identify, Transform, and Run jakarta.* application Aug 3, 2020
@lprimak
Copy link
Contributor

lprimak commented Aug 3, 2020

super cool!

Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs conflicts resolving and I'll approve

@MattGill98

This comment has been minimized.

@MattGill98

This comment has been minimized.

@jGauravGupta jGauravGupta merged commit eeb16a1 into payara:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants