-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-256 Identify, Transform, and Run jakarta.* application #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGauravGupta
changed the title
FISH-256 Identify, Transform, and Run Application jakarta.* application
FISH-256 Identify, Transform, and Run jakarta.* application
Aug 3, 2020
lprimak
approved these changes
Aug 3, 2020
super cool! |
MattGill98
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just needs conflicts resolving and I'll approve
nucleus/deployment/admin/src/main/java/fish/payara/deployment/admin/PayaraTransformer.java
Show resolved
Hide resolved
MattGill98
approved these changes
Aug 6, 2020
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gaurav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gupta [email protected]
Description
This is a feature to detect Jakarta EE 9 application and transform
jakarta.*
namespace tojavax.*
namespace then perform the usual deployment operation.Depends on PR
payara/transformer#1
payara/Payara_PatchedProjects#320
Testing
Testing Performed
Tested manually deployment of WAR module (.war), EAR module (.ear), EJB Module (.jar)
New Tests
Payara/appserver/tests/payara-samples/samples/jakartaee-namespace-transformer/src/test/java/fish/payara/samples/namespace/trasformer/HelloWorldControllerTest.java
Lines 78 to 87 in 81a4779
Documentation
payara/Payara-Community-Documentation#52