FISH-205 Implement Dynamic Micro Logging Properties #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
1 similar comment
|
jenkins test please |
Pandrex247
reviewed
Jun 29, 2020
...ra-executor-service/src/main/java/fish/payara/nucleus/executorservice/PayaraFileWatcher.java
Outdated
Show resolved
Hide resolved
...ra-executor-service/src/main/java/fish/payara/nucleus/executorservice/PayaraFileWatcher.java
Outdated
Show resolved
Hide resolved
|
I'll make all of the code style changes once I've had a functional review! |
Pandrex247
approved these changes
Jul 1, 2020
Created a file watching service that can be interacted with statically to allow the Payara Micro boot sequence to queue up paths to watch before HK2 starts. Works by allowing any classto register actions to complete when a specific file or path is modified. The static methods will still work post-startup as the loop checks the static list. Signed-off-by: Matthew Gill <[email protected]>
The flag isn't currently linked to anything, but whilst its non-functional the groundwork should still be in place to work properly in Payara Micro. Signed-off-by: Matthew Gill <[email protected]>
The --enableDynamicLogging option now makes use of the file watcher service to dynamically update logging properties. Signed-off-by: Matthew Gill <[email protected]>
|
jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running Payara Micro with
--enableDynamicLoggingthe logging properties file will be copied into the exploded directory and read again.Testing
To reproduce, use the following log properties file:
Run Payara Micro with --logproperties and notice that changing the file doesn't print anything.
Run Payara Micro also with --enableDynamicLogging and change the global log level to FINE. Notice that an INFO log appears saying log levels have been updated. Change the global log level back to INFO, and notice a new FINE level message has been logged.