FISH-1069 Rationalise fault tolerance docs #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the fault tolerance docs to reflect the new rationalised configuration. Signed-off-by: Matthew Gill <[email protected]>
fturizo
requested changes
Feb 17, 2021
| The executor service is used to execute methods annotated with `@Asynchronous`, whereas the scheduled executor | ||
| service is used by the CircuitBreaker and Timeout interceptors for their timeout operations (scheduling the circuit breaker | ||
| to be set to half open, and just timing out respectively). | ||
| The executor service is used to execute methods annotated with `@Asynchronous`, whereas the scheduled executor service is used by the CircuitBreaker and Timeout interceptors for their timeout operations (scheduling the circuit breaker to be set to half open, and just timing out respectively). |
There was a problem hiding this comment.
@MattGill98, I'm a bit confused by this statement. Is the gist of the clarification that there are 2 managed executor services used to coordinate these 3 interceptors, a plain ManagedExecutorService for the @Async interceptor and a ManagedScheduledExecutorService to handle the other 2 correct? If this is the case it might be better to put this on a list and annotate the interceptor names and put them in pre format for better readibility
There was a problem hiding this comment.
What do you mean sorry? I haven't actually edited this line, but I think it reads fairly clearly
OndroMih
approved these changes
Feb 25, 2021
MeroRai
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the fault tolerance docs to reflect the new rationalised
configuration.