Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-370 Created Microsoft Teams notifier #11

Merged
merged 7 commits into from
Oct 2, 2020
Merged

FISH-370 Created Microsoft Teams notifier #11

merged 7 commits into from
Oct 2, 2020

Conversation

Cousjava
Copy link
Contributor

No description provided.

@Cousjava Cousjava requested a review from MattGill98 September 30, 2020 16:18
MattGill98
MattGill98 suggested changes Oct 1, 2020
View reviewed changes
pom.xml Show resolved Hide resolved
...er-console-plugin/src/main/java/fish/payara/admingui/notifier/teams/TeamsNotifierPlugin.java Outdated Show resolved Hide resolved
teams-notifier-core/pom.xml Show resolved Hide resolved
teams-notifier-core/pom.xml Show resolved Hide resolved
...c/main/java/fish/payara/extensions/notifiers/teams/SetTeamsNotifierConfigurationCommand.java Show resolved Hide resolved
teams-notifier-core/src/main/java/fish/payara/extensions/notifiers/teams/TeamsNotifier.java Outdated Show resolved Hide resolved
teams-notifier-core/src/main/java/fish/payara/extensions/notifiers/teams/TeamsNotifier.java Outdated Show resolved Hide resolved
teams-notifier-core/src/main/java/fish/payara/extensions/notifiers/teams/TeamsNotifier.java Outdated Show resolved Hide resolved
MattGill98
MattGill98 reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few other comments to resolve

...src/main/resources/fish/payara/extensions/notifiers/teams/get-teams-notifier-configuration.1 Show resolved Hide resolved
MattGill98
MattGill98 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can remove the static USER_AGENT string that would be great, then I'm happy for this to be merged and released! Nice work 😄

@Cousjava Cousjava force-pushed the FISH-370-teams-notifier branch from 3fecec3 to 1a15b36 Compare October 2, 2020 13:20
@Cousjava Cousjava merged commit 511907b into payara:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGill98 MattGill98 MattGill98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cousjava @MattGill98