Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong results with exp(-8+) #378

Closed
schungx opened this issue May 22, 2021 · 2 comments · Fixed by #385
Closed

Wrong results with exp(-8+) #378

schungx opened this issue May 22, 2021 · 2 comments · Fixed by #385

Comments

@schungx
Copy link
Contributor

schungx commented May 22, 2021

When exp with 0.0002 tolerance goes around -8 to -8.5, the result starts flipping into negative.

Which is, of course, incorrect, as there is no index for exp that turns out negative.

@paupino
Copy link
Owner

paupino commented May 23, 2021

One option here, since it is unlikely to converge, is to return the previous positive result which would be closer? What do you think?

@schungx
Copy link
Contributor Author

schungx commented May 24, 2021

Or clamp it down to zero once it flips... or raise an underflow error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants