Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use modern Solidity instead of assembly for codesize #19

Closed
wants to merge 0 commits into from

Conversation

transmissions11
Copy link
Contributor

fixes #18

@transmissions11
Copy link
Contributor Author

not sure if this saves gas... is there a script we can use to profile?

@PaulRBerg
Copy link
Owner

In most cases setting up a gas profiler takes more than time than just spinning up Remix and creating two functions foo and bar with the different implementations.

Especially since hardhat-gas-reporter doesn't work with constant functions.

@PaulRBerg PaulRBerg changed the base branch from main to staging March 10, 2022 11:57
@PaulRBerg PaulRBerg closed this Mar 10, 2022
@PaulRBerg
Copy link
Owner

PaulRBerg commented Mar 10, 2022

Hi @transmissions11, I force-pushed a commit onto your fork, trying to fix the git conflicts, and the PR got automatically closed by GitHub. Sorry!

@transmissions11
Copy link
Contributor Author

Np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use high-level Solidity to read contract size
2 participants