Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array#slice bug #322

Closed
zloirock opened this issue Feb 26, 2015 · 2 comments
Closed

Array#slice bug #322

zloirock opened this issue Feb 26, 2015 · 2 comments
Assignees
@ljharb
Labels
Spec compliance

Comments

@zloirock
Copy link

About bdd9804 / compat-table/compat-table#453

By spec, ArraySpeciesCreate shoud create instance arrayLike.constructor / arrayLike.constructor[@@spicies] only if arrayLike is array, see steps 4-7.

Current implementation different from spec and breaks old code - for example, [].slice.call(document.getElementsByTagName('div')) throws error.
@ljharb
Copy link
Collaborator

ljharb commented Feb 26, 2015

Unpublished v0.27.0 from npm pending this issue.

@ljharb ljharb self-assigned this Feb 26, 2015
@ljharb
Copy link
Collaborator

ljharb commented Mar 5, 2015

After rereading the spec algorithm, I think that perhaps this isn't shimmable. I'm going to revert this for now and revisit it in the future.

@ljharb ljharb closed this as completed in b9afbde Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljharb ljharb

Labels
Spec compliance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @zloirock