Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault caused by RtcpReceivingSession #1027

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Fix segfault caused by RtcpReceivingSession #1027

merged 1 commit into from
Nov 4, 2023

Conversation

Sean-Der
Copy link
Contributor

@Sean-Der Sean-Der commented Nov 2, 2023

RtcpReceivingSession was incorrectly returning a message_vector containing nullptr.

Fixes #1026

@Sean-Der
Fix segfault caused by RtcpReceivingSession
b9cc1ae 
RtcpReceivingSession was incorrectly returning a `message_vector`
containing nullptr.

Fixes paullouisageneau#1026
@chobie chobie mentioned this pull request Nov 4, 2023
Merged
paullouisageneau
paullouisageneau approved these changes Nov 4, 2023
View reviewed changes
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, and sorry for the regression. I thought I fixed this already, it looks like I have messed up somehow.

@paullouisageneau paullouisageneau merged commit 6a98f62 into paullouisageneau:master Nov 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullouisageneau paullouisageneau paullouisageneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault in RtcpReceivingSession
2 participants
@Sean-Der @paullouisageneau