Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue of RtcpNackResponder nack data #1117

Closed
hqs1 opened this issue Feb 23, 2024 · 4 comments · Fixed by #1118
Closed

Issue of RtcpNackResponder nack data #1117

hqs1 opened this issue Feb 23, 2024 · 4 comments · Fixed by #1118

Comments

@hqs1
Copy link

hqs1 commented Feb 23, 2024

Hello, I am using libchannel and the nack data seems to be inconsistent with the media source data. The data sent by the same sequenceNumber and nack seems to use the same message_ptr. It seems that the data sent by nack has secondary encryption.

The storage media data here appears to be weakly referenced

mStorage->store(message);

thank you !

@paullouisageneau
Copy link
Owner

Ow, indeed, this is due to SRTP encryption happening in-place so messages referenced by RtcpNackResponder end up corrupted. I'm pushing a fix.

@paullouisageneau
Copy link
Owner

Thank you for reporting, it should be fixed by #1118

@hqs1
Copy link
Author

hqs1 commented Feb 23, 2024

Ok, thanks. I'll test it and give feedback.

@hqs1
Copy link
Author

hqs1 commented Feb 26, 2024

After testing, it can be retransmitted normally.

@hqs1 hqs1 closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants