Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For unseekable files, can't build full index by reading the entire file #107

Open
epicfaace opened this issue Oct 19, 2022 · 8 comments
Open

Comments

@epicfaace
Copy link
Contributor

For unseekable files, can't build full index by reading the entire file. I have to run build_full_index, but I can't just instead read the entire file to build the index (which ideally should be equivalent and should work as well). See #106 for a reproduction.

@pauldmccarthy
Copy link
Owner

Hi @epicfaace, sorry - I'm on holiday until early November, so won't be able to look into this until then. Is it by any chance related to #74?

@epicfaace
Copy link
Contributor Author

No worries! I don't know if it's related to #74, but perhaps it is. I'll take a look.

cc @wwwjn -- I think this is the issue we're stuck on

@wwwjn
Copy link

wwwjn commented Nov 2, 2022

Hi @pauldmccarthy, do you have some bandwidth to look into this issue or its there any progress? Thanks a lot!

@epicfaace
Copy link
Contributor Author

He's on holiday 🙂 but we should probably try to do as much as we can to help in the meantime -- maybe debugging, trying to find a minimal reproducible example, seeing if we can also figure out a fix

@epicfaace
Copy link
Contributor Author

Hi @pauldmccarthy , wanted to see if you might have gotten a chance to look into this issue!

@pauldmccarthy
Copy link
Owner

@epicfaace Sorry, I've had a busy couple of months. I might find time to look at this over the Christmas break, but feel free to dive into it if either of you have time,.

@wwwjn
Copy link

wwwjn commented Jan 4, 2023

@pauldmccarthy Wish you have a great holidays! Is there any update on this issue? I try to take a look about this issue but can not find a solution to this...

@pauldmccarthy
Copy link
Owner

Hi @wwwjn, sorry, I really don't have time to look at non-critical issues at the moment. But I'm happy to review PRs if you have the time to do the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants