Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleBaseMenuProps - interface has been removed #165

Closed
nicolethoen opened this issue Dec 8, 2022 · 2 comments
Closed

ToggleBaseMenuProps - interface has been removed #165

nicolethoen opened this issue Dec 8, 2022 · 2 comments
Labels
codemod pf5 codemod for p4 to p5 transition

Comments

@nicolethoen
Copy link
Contributor

Follow up to breaking change PR patternfly/patternfly-react#8235

Any consumer importing ToggleBaseMenuProps should be warned that it no longer exists. Or possibly the code mod can remove the import statement and any reference to the interface? @jenny-s51 is there anything else that should be considered?

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@jenny-s51
Copy link
Contributor

jenny-s51 commented Dec 21, 2022

@nicolethoen I think we can warn the consumer that the interface has been removed, and maybe provide a template for replacing it with menuAppendTo from a specific component similar to how Keycloak did this!

Repository owner moved this from Not started to Done in PatternFly Issues Dec 21, 2022
@jenny-s51 jenny-s51 reopened this Dec 21, 2022
Repository owner moved this from Done to Not started in PatternFly Issues Dec 21, 2022
@jenny-s51
Copy link
Contributor

jenny-s51 commented Dec 21, 2022

This seems to be a duplicate of #143 which was opened first - closing as a duplicate if that's okay.

@jenny-s51 jenny-s51 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2022
Repository owner moved this from Not started to Done in PatternFly Issues Dec 21, 2022
@gitdallas gitdallas added pf5 codemod for p4 to p5 transition codemod labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codemod pf5 codemod for p4 to p5 transition
Projects
Archived in project
Development

No branches or pull requests

3 participants