Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleList: Replace prop isCurrent with isActive #133

Closed
evwilkin opened this issue Nov 23, 2022 · 0 comments · Fixed by #186
Closed

SimpleList: Replace prop isCurrent with isActive #133

evwilkin opened this issue Nov 23, 2022 · 0 comments · Fixed by #186
Assignees
@wise-king-sullyman
Labels
codemod pf5 codemod for p4 to p5 transition
Milestone
2023.01

Comments

@evwilkin
Copy link
Member

Issue: patternfly/patternfly-react#8132

isCurrent is deprecated and has been replaced with isActive - functionality remains the same, only name has changed.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@evwilkin evwilkin changed the title Replace isCurrent with isActive SimpleList: Replace prop isCurrent with isActive Nov 23, 2022
@wise-king-sullyman wise-king-sullyman self-assigned this Dec 7, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Dec 12, 2022
@nicolethoen nicolethoen added this to the 2023.01 milestone Dec 21, 2022
@wise-king-sullyman wise-king-sullyman mentioned this issue Jan 3, 2023
Merged
@wise-king-sullyman wise-king-sullyman moved this from Not started to PR Review in PatternFly Issues Jan 3, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 9, 2023
@gitdallas gitdallas added the pf5 codemod for p4 to p5 transition label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod pf5 codemod for p4 to p5 transition
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
Development

Successfully merging a pull request may close this issue.

feat(simpleList): rename isCurrent to isActive wise-king-sullyman/pf-codemods
4 participants
@gitdallas @wise-king-sullyman @evwilkin @nicolethoen