-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Code Editor - Replace react-monaco-editor
with @monaco-editor/react
#8578
Comments
Alternatively a new package could be created and published under a new major of |
Consider for post v5 as an Editor-Next component. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This comment was marked as off-topic.
This comment was marked as off-topic.
I like the idea behind this. We are using Vite for our product, which doesn't use Webpack. Making Patternfly independent of frameworks should be a requirement. |
So having explored |
hi, In cockpit we are implementing a new plugin for FS browsing. https://github.com/KKoukiou/cockpit-navigator We tried using this editor - but it's partially broken due to CSP. Nothing unexpected since the used module has the same CSP issues. microsoft/monaco-editor#271 Did you try the suggested alternative module, but it looks like the CSP issues are fixed. suren-atoyan/monaco-react#83 Thanks for prioritizing this. |
The
react-monaco-editor
package should be replaced with@monaco-editor/react
. The latter is much more mature and receives more frequent updates, specifically:I think this would be a good candidate for the next major version of PatternFly React.
The text was updated successfully, but these errors were encountered: