Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: evaluate usage of jest.spyOn().mockImplementation() in our test suites #7933

Closed
wise-king-sullyman opened this issue Sep 2, 2022 · 5 comments
Closed

Chore: evaluate usage of jest.spyOn().mockImplementation() in our test suites #7933

wise-king-sullyman opened this issue Sep 2, 2022 · 5 comments
Labels
wontfix

Comments

@wise-king-sullyman
Copy link
Contributor

After some investigation I've discovered that we probably don't want to use .mockImplementation() on our spies everywhere that we currently are, and that where we do use it we need to ensure that we restore the original behavior of the object we are spying on to prevent unintended side effects which can impact the reliability of our tests.
@mcarrano mcarrano added this to the 2022.14 milestone Sep 13, 2022
@mcarrano mcarrano modified the milestones: 2022.14, 2023.02 Sep 27, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Oct 5, 2022
@mcarrano mcarrano modified the milestones: 2023.02, 2023.01 Oct 26, 2022
@mcarrano mcarrano modified the milestones: 2023.01, Prioritized Backlog Nov 29, 2022
@stale
Copy link

stale bot commented Jan 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 29, 2023
@stale
Copy link

stale bot commented Mar 31, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 31, 2023
@stale
Copy link

stale bot commented Jun 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jun 26, 2023
@stale
Copy link

stale bot commented Sep 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Sep 3, 2023
@stale Stale
Copy link

stale bot commented Nov 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 10, 2023
@stale stale bot closed this as completed Nov 24, 2023
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Nov 24, 2023
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcarrano @wise-king-sullyman @nicolethoen @tlabaj