Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore - remove KEY_CODES definition #7929

Closed
tlabaj opened this issue Sep 2, 2022 · 1 comment · Fixed by #8174
Closed

chore - remove KEY_CODES definition #7929

tlabaj opened this issue Sep 2, 2022 · 1 comment · Fixed by #8174
Assignees
@gitdallas
Labels
Breaking change 💥 this change requires a major release and has API changes. Good first issue Hacktoberfest 🎃 PF5
Milestone
2022.14

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Sep 2, 2022 •
edited
Loading

Remove KEY_CODES definition from helpers\constants. We should discourage use of key codes in our code base since user-event no longer supports them.
@tlabaj tlabaj added the Breaking change 💥 this change requires a major release and has API changes. label Sep 2, 2022
@tlabaj tlabaj added this to the Breaking Changes milestone Sep 2, 2022
@nicolethoen nicolethoen moved this to Breaking change in PatternFly Issues Sep 6, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2022.14 Sep 27, 2022
@nicolethoen nicolethoen moved this from Breaking change to Not started in PatternFly Issues Oct 5, 2022
@tlabaj tlabaj mentioned this issue Oct 10, 2022
Merged
@tlabaj
Copy link
Contributor Author

tlabaj commented Oct 10, 2022

closed by #8174

@tlabaj tlabaj closed this as completed Oct 10, 2022
Repository owner moved this from Not started to Done in PatternFly Issues Oct 10, 2022
@nicolethoen nicolethoen added the PF5 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitdallas gitdallas

Labels
Breaking change 💥 this change requires a major release and has API changes. Good first issue Hacktoberfest 🎃 PF5
Projects
PatternFly Issues
Archived in project
Milestone
2022.14
Development

Successfully merging a pull request may close this issue.

chore: remove keycodes definition gitdallas/patternfly-react
3 participants
@gitdallas @nicolethoen @tlabaj