Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4 Tabs Invalid prop forwardRef supplied to Tab #2132

Closed
idevat opened this issue Jun 3, 2019 · 2 comments
Closed

PF4 Tabs Invalid prop forwardRef supplied to Tab #2132

idevat opened this issue Jun 3, 2019 · 2 comments

Comments

@idevat
Copy link

idevat commented Jun 3, 2019

There's an issue with version 3.32.5 (recommended in issue #2100).

Component:

import React from "react";
import { Tabs, Tab } from "@patternfly/react-core";

const Test = () => (
  <Tabs activeKey={0}>
    <Tab eventKey={0} title="Tab0">
      Tab0
    </Tab>
    <Tab eventKey={1} title="Tab1">
      Tab1
    </Tab>
  </Tabs>
);

export default Test;

produces warning:
tabs_issue

This issue does not occur in a version 3.16.10

@redallen
Copy link
Contributor

redallen commented Jun 3, 2019

This has to do with our incorrect PropTypes. I just opened a PR to fix it!

@jschuler
Copy link
Collaborator

jschuler commented Jun 5, 2019

Thanks @redallen I see your fix covered it as well, I have merged a fix just for tabs that also addresses this

@jschuler jschuler closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants