Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an nvmrc file #682

Closed
bmuenzenmeyer opened this issue Sep 17, 2017 · 2 comments
Closed

Add an nvmrc file #682

bmuenzenmeyer opened this issue Sep 17, 2017 · 2 comments
Assignees
@bmuenzenmeyer
Labels
enhancement ✨ staged for next release 🏁
Milestone
3.0.0

Comments

@bmuenzenmeyer
Copy link
Member

It'd be smart to tell users what Node version we officially support
@bmuenzenmeyer bmuenzenmeyer added this to the 3.0.0 milestone Sep 17, 2017
@bmuenzenmeyer bmuenzenmeyer self-assigned this Sep 17, 2017
@tburny
Copy link

tburny commented Sep 27, 2017

I would suggest using the latest currently available LTS version here, including the minor version.

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Sep 27, 2017 •
edited
Loading

What are you suggesting? updating the engines property in package json to match the nvmrc?

Current LTS is....

https://nodejs.org/download/release/latest-v6.x/
ab99d50#diff-ae9eba3500703eaba1d5b8e13832d955

at least until https://github.com/nodejs/Release switches it to 8 sometime in October....

@snyk-bot snyk-bot mentioned this issue Sep 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
enhancement ✨ staged for next release 🏁
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@bmuenzenmeyer @tburny