This repository has been archived by the owner on Dec 10, 2019. It is now read-only.
Regex update 2 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that pattern-lab/patternlab-node#277 was closed for reasons stated in pattern-lab/patternlab-node#603 , there is no reason to exclude this pr and branch from the routine pruning of my stale prs and branches. Closing pr. Deleting branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses pattern-lab/patternlab-node#250
Summary of changes:
In order to get #250 done,
findPartialneeds to find partials with parameters with newlines. Also, the broken apart and documented regex string has become indispensable.