-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more entities #57
Added more entities #57
Conversation
You'll need to rebase against master @rockeynebhwani :) |
@patrickhulce - can you have check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data itself LGTM, just a few formatting nits!
@@ -4212,7 +4212,8 @@ | |||
{ | |||
"name": "Evergage", | |||
"categories": ["analytics"], | |||
"domains": ["*.evergage.com"] | |||
"domains": ["*.evergage.com", "*.evgnet.com"] | |||
"examples": ["cdn.evgnet.com"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"examples": ["cdn.evgnet.com"] | |
"examples": ["cdn.evgnet.com"] |
Co-Authored-By: Patrick Hulce <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing the whitespace issue would've been appreciated too for future reference :)
Thanks @patrickhulce ... Sorry.. I got distracted with something else.. will take care in future |
No description provided.