Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more entities #57

Merged
merged 8 commits into from
Jul 23, 2019
Merged

Added more entities #57

merged 8 commits into from
Jul 23, 2019

Conversation

rockeynebhwani
Copy link
Contributor

No description provided.

@patrickhulce
Copy link
Owner

You'll need to rebase against master @rockeynebhwani :)

@rockeynebhwani
Copy link
Contributor Author

@patrickhulce - can you have check now?

Copy link
Owner

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data itself LGTM, just a few formatting nits!

@@ -4212,7 +4212,8 @@
{
"name": "Evergage",
"categories": ["analytics"],
"domains": ["*.evergage.com"]
"domains": ["*.evergage.com", "*.evgnet.com"]
"examples": ["cdn.evgnet.com"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"examples": ["cdn.evgnet.com"]
"examples": ["cdn.evgnet.com"]

Copy link
Owner

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing the whitespace issue would've been appreciated too for future reference :)

@patrickhulce patrickhulce merged commit d7a451f into patrickhulce:master Jul 23, 2019
@rockeynebhwani
Copy link
Contributor Author

Thanks @patrickhulce ... Sorry.. I got distracted with something else.. will take care in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants