Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using a single quote in meta fields leads to invalid HTML #176

Closed
philipdanielhayton opened this issue Mar 20, 2023 · 4 comments
Closed

Using a single quote in meta fields leads to invalid HTML #176

philipdanielhayton opened this issue Mar 20, 2023 · 4 comments

Comments

@philipdanielhayton
Copy link

Hi Patrick,

I've just noticed that the meta tag attributes use single quotes, which leads to invalid markup when the value itself contains a single quote.

For example if the og:title is set to "What's on" then the markup looks like this

<meta property='og:title' content='What's on in' />

I don't think it's a massive issue but it's flagging as an error in https://validator.w3.org.
@patrickdemooij9
Copy link
Owner

That will indeed cause some issues. I'll get on it right away!

@patrickdemooij9
Copy link
Owner

Fixed by commit 2e41c7d. Will try to get a new version out tomorrow

@philipdanielhayton
Copy link
Author

Legend, thanks for fixing so quickly!

@patrickdemooij9
Copy link
Owner

This has been fixed in the latest versions! Thanks again for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickdemooij9 @philipdanielhayton