Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling document type meta fields #15

Closed
patrickdemooij9 opened this issue Feb 26, 2022 · 6 comments · Fixed by #78
Closed

Update styling document type meta fields #15

patrickdemooij9 opened this issue Feb 26, 2022 · 6 comments · Fixed by #78
Labels
Enhancement New feature or request Metafields
Milestone

Comments

@patrickdemooij9
Copy link
Owner

Few styling changes to make for the meta fields content app for the document type:

  • See if we can have the "Enable seo settings" take less space. Should check if Umbraco has anything like this in place.
  • See if we can improve the UI for the "Open settings" button. Possibly moving all the sidepanel logic to the main panel. Just have to make sure that the main panel doesn't get too cluttered with information for the user.
  • See if we can use markup for the field descriptions. Might help the developer/user with setting up the fields. Target group is developers, but it would be nice to provide some extra information anyway.
@leekelleher
Copy link
Contributor

leekelleher commented Feb 27, 2022

@patrickdemooij9 I've been hacking around with a potential alternative.
Of course, it's still a work-in-progress, but let me know what you think of this...

The default state, a <umb-box-header> with a <umb-toggle> and label...
Screenshot 2022-02-27 222052

I'm not fully convinced about the "Enable SEO settings?" label/toggle being right aligned, but left aligned would feel odd too. 🤔

When enabled, the toggle's label is hidden (I did have it saying "Disable SEO settings?" but that felt odd), and the tabs are displayed in the <umb-box-header> title area.

Screenshot 2022-02-27 222122

@patrickdemooij9
Copy link
Owner Author

@leekelleher
I think it does look very good. I think aligning it on the right is the right call here and I don't think there will ever be that many tabs that it'll cause an issue here.

It does feel a bit odd in the way that all configuration actions for document types are on the left while this one is on the right, but I wouldn't worry about it that much. I think it is definitely an improvement on the current implementation.

There also isn't really any way Umbraco currently does this. There is the "Enable List view", but that of course doesn't have tabs so it can be used a bit easier here.

@patrickdemooij9 patrickdemooij9 added Enhancement New feature or request Metafields labels Feb 28, 2022
@patrickdemooij9 patrickdemooij9 added this to the V1 Release milestone Feb 28, 2022
@leekelleher
Copy link
Contributor

Coming back to it a day later, the "Enable SEO settings?" being right aligned still isn't feeling right to me.
I'm happy to send over a pull-request, if you want the code - but I can't say that I'm completely happy with my progress at the moment.

@patrickdemooij9
Copy link
Owner Author

We can just put it on the "possible solutions" pile for now. Will see if I can also come up with some solutions later today so we have some more solutions to compare with

@patrickdemooij9
Copy link
Owner Author

I tried out a few things:

1:
image

2:
image

3:
image

4:
image

I think buttons might even be nicer here than a random checkbox, but still not quite sure. I do wonder if tabs are the way to go or if I should have different boxes for each setting. Just worried it will be a lot of content on one page then.

@leekelleher
Copy link
Contributor

I'm liking number 3, the button does make a difference to it being a toggle.

I thought the same about swapping tabs for boxes/fieldsets going down the page. I don't think it'd feel too long for someone configuring the doctype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Metafields
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants