Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about comment of the "include_original" in Augment #49

Open
sgdy3 opened this issue Sep 11, 2022 · 0 comments
Open

Confusion about comment of the "include_original" in Augment #49

sgdy3 opened this issue Sep 11, 2022 · 0 comments

Comments

@sgdy3
Copy link

sgdy3 commented Sep 11, 2022

Hi, Patrick.
Thanks for your code and Document. They really help me a lot. However, I found a little "mistake" in the interpolation about the parameter "include_original" in class Augment. It says that when "include_original" is set to be True, then for each $\Phi(x_i,...,x_{k+i-1})$, original element of the sequence will be included as well. And the output is of the form $(,x_i,\phi(x_i,...,x_{k+i-1}))$. But when I dived into the source code of "Augment", I noticed that it actually be $(,x_{k+i-1},\phi(x_i,..x_{k+i-1}))$. I'm not sure whether this inconsistence is intentional or actually a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant