Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can select date returns true always #24

Closed
patchthecode opened this issue May 24, 2016 · 1 comment
Closed

Can select date returns true always #24

patchthecode opened this issue May 24, 2016 · 1 comment
Assignees
@patchthecode
Labels
Already Fixed on Master Branch bug

Comments

@patchthecode
Copy link
Owner

From this user.
#16

That being said, I found that result of delegate's calendar(_:, canSelectDate:, cell:, cellState:) method is not used, since the place where it's called (in collectionView(collectionView:, shouldSelectItemAtIndexPath indexPath:), I recall) always returns true instead of using the result. I could create a pull request if you want to, but I afraid my fork deviates too far away from the original 😬 and it wouldn't take much to fix that bug, IMO 😄
@patchthecode patchthecode mentioned this issue May 24, 2016
Closed
@patchthecode patchthecode self-assigned this May 24, 2016
@patchthecode patchthecode added this to the Bugs 3.0 milestone May 24, 2016
@patchthecode
Copy link
Owner Author

Fixed and pushed to master

@rzzvn rzzvn mentioned this issue Nov 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patchthecode patchthecode

Labels
Already Fixed on Master Branch bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patchthecode