Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ruby 3.1 & 3.2, drop 2.5 & 2.6 #1237

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Test ruby 3.1 & 3.2, drop 2.5 & 2.6 #1237

merged 1 commit into from
Dec 30, 2022

Conversation

jdelStrother
Copy link
Contributor

Which version you want to support is up to you, but given ruby 2.6 is no longer supported by the ruby team, maybe it's time to drop it from CI?

The matrix.exclude option is getting kind of verbose - wondered if there was a shorter alternative with matrix.include but not sure it's possible.

@jdelStrother
Copy link
Contributor Author

I see I missed bumping the manticore service. I'll take another run at this tomorrow

@pat
Copy link
Owner

pat commented Dec 30, 2022

Thanks @jdelStrother for all the patience and prodding. I'm going to merge this in now, happy for Manticore update to be separate. Plus, I want to see if I can wrangle better pagination support for Manticore, but that'll be after the upcoming release.

@pat pat merged commit 39584f1 into pat:develop Dec 30, 2022
@pat
Copy link
Owner

pat commented Dec 30, 2022

Also worth noting: there's still CircleCI tests that run against Rails 4.2 and Sphinx 2.2 (using Ruby 2.4 😅), because I can't install Sphinx 2.2 on GitHub's more 'modern' workers (Ubuntu 18.04). But maybe it's well and truly time to retire Rails 4.2 support! It's more the loss of testing against Sphinx 2.2.11 that I'm not thrilled about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants