Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load ActiveRecord during rails initialization #1194

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

jdelStrother
Copy link
Contributor

If ThinkingSphinx requires ActiveRecord on load, then setting configuration in applications' initializers with have no effect (eg
Rails.application.config.active_record.has_many_inversing).

Instead, ActiveRecord should be deferred to the end of initialization using the Railtie. WDYT to something like this?

If ThinkingSphinx requires ActiveRecord on load, then setting
configuration in applications' initializers with have no effect (eg
Rails.application.config.active_record.has_many_inversing).

Instead, ActiveRecord should be deferred to the end of initialization
using Railtie
@pat
Copy link
Owner

pat commented Apr 30, 2021

Looks good to me - and thanks for figuring out the fix! Must have been a frustrating thing to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants