Use instances for index filtering from callbacks. #1171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by discussions in #1166, this PR changes the IndexSet class to accept
:instances
alongside the:classes
option, which could allow custom subclasses of IndexSet to filter returned indices to a subset as determined by the provided instances.In particular, if you're sharding your indices, you can return just the specific shard of indices for the instance, rather than all shards:
While it's not necessary moving forward, I'm still passing through the
:classes
option for anyone who's got a custom IndexSet class that depends on that.