Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive -To methods #51

Merged
merged 23 commits into from
Jan 2, 2019
Merged

Revive -To methods #51

merged 23 commits into from
Jan 2, 2019

Conversation

passsy
Copy link
Owner

@passsy passsy commented Dec 31, 2018

Followup to #46, adding all removed functions again.

The bug in dart dart-lang/sdk#35518 still exists but it is possible to work around it. It's possible to check they incoming type at runtime. This doesn't make the API statically typed but I rather provide the methods with a runtime check to users than not providing the methods.

It will be non-breaking to change the API to be statically typed, once a bugfix landed.

Revived:

  • KIterable<T>.associateWithTo
  • Kiterable<T>.filterTo
  • KIterable<T>.filterIndexedTo
  • KIterable<T>.filterNotTo
  • KIterable<T>.filterNotNullTo
  • KIterable<T>.groupByTo
  • KMap<T>.mapKeysTo
  • KMap<T>.mapValuesTo

fix KSet equals

Also I fixed the equals implementation of Set, which wasn't working properly when comparing KSet<int> to KSet<num>

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #51 into master will increase coverage by 0.55%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   93.88%   94.44%   +0.55%     
==========================================
  Files          25       25              
  Lines        1538     1603      +65     
==========================================
+ Hits         1444     1514      +70     
+ Misses         94       89       -5
Impacted Files Coverage Δ
lib/src/collection/list_mutable.dart 100% <ø> (ø) ⬆️
lib/src/extension/map_extensions_mixin.dart 100% <100%> (+3.17%) ⬆️
lib/src/collection/set.dart 100% <100%> (ø) ⬆️
lib/src/collection/set_mutable.dart 81.33% <100%> (+0.25%) ⬆️
lib/src/extension/iterable_extension_mixin.dart 96.71% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd8369...78eb6c1. Read the comment docs.

@passsy passsy merged commit 26bb0ee into master Jan 2, 2019
@passsy passsy deleted the feature/revive_-To_methods_dynamically branch January 2, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant