-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive -To methods #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New lint checks will warn if they are missing in the future
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 93.88% 94.44% +0.55%
==========================================
Files 25 25
Lines 1538 1603 +65
==========================================
+ Hits 1444 1514 +70
+ Misses 94 89 -5
Continue to review full report at Codecov.
|
Not that is helps, but it reduces discussions about whether or this missing piece might cause the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #46, adding all removed functions again.
The bug in dart dart-lang/sdk#35518 still exists but it is possible to work around it. It's possible to check they incoming type at runtime. This doesn't make the API statically typed but I rather provide the methods with a runtime check to users than not providing the methods.
It will be non-breaking to change the API to be statically typed, once a bugfix landed.
Revived:
KIterable<T>.associateWithTo
Kiterable<T>.filterTo
KIterable<T>.filterIndexedTo
KIterable<T>.filterNotTo
KIterable<T>.filterNotNullTo
KIterable<T>.groupByTo
KMap<T>.mapKeysTo
KMap<T>.mapValuesTo
fix
KSet
equalsAlso I fixed the equals implementation of Set, which wasn't working properly when comparing
KSet<int>
toKSet<num>