Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input arguments #36

Merged
merged 10 commits into from
Dec 23, 2018
Merged

Validate input arguments #36

merged 10 commits into from
Dec 23, 2018

Conversation

passsy
Copy link
Owner

@passsy passsy commented Dec 21, 2018

Prevent errors early and give useful errors for developers.
Moved argument checks inside assert blocks so they don't get executed in production

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #36 into master will increase coverage by 0.68%.
The diff coverage is 70.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   74.48%   75.16%   +0.68%     
==========================================
  Files          25       25              
  Lines        1203     1502     +299     
==========================================
+ Hits          896     1129     +233     
- Misses        307      373      +66
Impacted Files Coverage Δ
...rc/extension/iterable_mutable_extension_mixin.dart 0% <0%> (ø) ⬆️
lib/src/extension/map_extensions_mixin.dart 100% <100%> (ø) ⬆️
lib/src/collection/set_empty.dart 80.95% <100%> (+3.17%) ⬆️
...ib/src/extension/list_mutable_extension_mixin.dart 100% <100%> (ø) ⬆️
lib/src/collection/set.dart 100% <100%> (ø) ⬆️
lib/src/collection/list.dart 100% <100%> (ø) ⬆️
...ib/src/extension/map_mutable_extensions_mixin.dart 94.11% <100%> (+3.2%) ⬆️
lib/src/collection/map_mutable.dart 85.91% <100%> (-0.66%) ⬇️
lib/src/extension/list_extension_mixin.dart 40.77% <31.25%> (-5.28%) ⬇️
lib/src/extension/iterable_extension_mixin.dart 69.81% <68.68%> (+2.26%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0ae8c...df0e94d. Read the comment docs.

@passsy
Copy link
Owner Author

passsy commented Dec 23, 2018

I manually checked the diff. All previously covered methods have now covered argument checks. Uncovered methods have uncovered argument checks. Those added checks increase the uncovered part of the lib in this diff.

@passsy passsy merged commit dac4d84 into master Dec 23, 2018
@passsy passsy deleted the feature/check_args_in_asserts branch December 23, 2018 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant