-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate input arguments #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 74.48% 75.16% +0.68%
==========================================
Files 25 25
Lines 1203 1502 +299
==========================================
+ Hits 896 1129 +233
- Misses 307 373 +66
Continue to review full report at Codecov.
|
I manually checked the diff. All previously covered methods have now covered argument checks. Uncovered methods have uncovered argument checks. Those added checks increase the uncovered part of the lib in this diff. |
Prevent errors early and give useful errors for developers.
Moved argument checks inside assert blocks so they don't get executed in production