Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second associateBy parameter, replace with associateByTransform #17

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

passsy
Copy link
Owner

@passsy passsy commented Dec 6, 2018

Remove second associateBy parameter, replace with associateByTransform with two parameters

associateBy is much more often used with a single parameter. This wasn’t possible until now because the second lambda value type V couldn’t only be known when the second lambda was provided

…m with two parameters

associateBy is much more often used with a single parameter. This wasn’t possible until now because the second lambda value type V couldn’t only be known when the second lambda was provided
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #17 into master will increase coverage by 0.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   56.66%   57.42%   +0.75%     
==========================================
  Files          24       24              
  Lines        1170     1172       +2     
==========================================
+ Hits          663      673      +10     
+ Misses        507      499       -8
Impacted Files Coverage Δ
lib/src/extension/iterable_extension_mixin.dart 49.69% <100%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7b93c...b73e81e. Read the comment docs.

@passsy passsy merged commit 06b27ff into master Dec 6, 2018
@passsy passsy deleted the feature/fix_associate branch December 6, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant