Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove const constructors from interfaces #12

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

passsy
Copy link
Owner

@passsy passsy commented Dec 2, 2018

Interfaces aren’t meant to be extended, only implemented. const or not const is the responsibility of the implementing class, not the interface.

The where required in the early stages of this project because the actual classes where extending not implementing the interfaces.

Interfaces aren’t meant to be extended, only implemented. Const or not const is the responsibility of the implementing class
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d3e16ff). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   54.88%           
=========================================
  Files             ?       27           
  Lines             ?     1135           
  Branches          ?        0           
=========================================
  Hits              ?      623           
  Misses            ?      512           
  Partials          ?        0
Impacted Files Coverage Δ
lib/src/collection/list_empty.dart 64.1% <ø> (ø)
lib/src/collection/set_empty.dart 44.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e16ff...8414338. Read the comment docs.

@passsy passsy merged commit 62cd869 into master Dec 2, 2018
@passsy passsy deleted the feature/remove_unneccessary_const_constructors branch December 2, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant