Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in the analysis_options.yaml file break customization #5

Closed
kuhnroyal opened this issue Jan 7, 2020 · 3 comments
Closed

Comments

@kuhnroyal
Copy link

I am creating this issue after my comment here: #3 (comment)

After further testing, I have discovered that the comment ins the analysis_options.yaml file break the possibility of customization. This may occur due to some YAML library parsing problems, maybe some undocumented handling of comment nodes, no idea.

I have done the following to determine this:

  1. Try to use pedenatic package and extend the rules adding and disabling - this works - pedantic has no comments in their files
  2. Copy the analysis_options.yaml file of this library to a local project file - customization does not work
  3. Remove all comments form the local file - customization works
@Afsar-Pasha
Copy link

5371885#diff-4bbaceb22700a77fd30e9913c8693dd1R395 (line with only "-") this caused the issue, fixed in baed5a1#diff-4bbaceb22700a77fd30e9913c8693dd1L406, wait until new version is released.

@kuhnroyal
Copy link
Author

Ah nice, must have missed this.
I guess I keep the issue open until the next version is released.
@passsy Can you pick this into the 2.7 branch?

@passsy
Copy link
Owner

passsy commented Jan 10, 2020

Thanks for reporting @kuhnroyal and nailing down the problem @Afsar-Pasha!

I published v1.1.1 including the fix

@passsy passsy closed this as completed in caf1ba2 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants