Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape Custom Dashboard Users #2911

Closed
erichfi opened this issue Sep 24, 2024 · 1 comment · Fixed by #2921, passportxyz/passport-scorer#684, #2925, passportxyz/passport-scorer#685 or passportxyz/eas-proxy#65
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Sep 24, 2024

No description provided.

@erichfi erichfi moved this to In Progress (WIP) in Passport New Sep 26, 2024
@nutrina
Copy link
Collaborator

nutrina commented Sep 26, 2024

For the smart contract changes:

  • we need to track the default scorer_id in the resolver smart contract
  • create a new nested map, for example mapping(address => mapping(uint256 => CachedScore)) public customScorer; // or communityScores
  • writing:
    • we will write all new scores for the default scorer in the old map, named scores
    • all other scores we will write to customScorer
  • add another getter to both the Resolver and Decoder contracts: getCachedCustomScore(...) respectively getCustomScore(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment