Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to pure JavaScript Action? #21

Closed
davidparsson opened this issue Jan 21, 2021 · 2 comments · Fixed by #22
Closed

Convert to pure JavaScript Action? #21

davidparsson opened this issue Jan 21, 2021 · 2 comments · Fixed by #22

Comments

@davidparsson
Copy link
Contributor

Hi, and thanks for the action!

Is there any specific reason for this not being a pure JavaScript action? They're faster, and implementing that seems rather simple.
@pascalgn
Copy link
Owner

This request seems familiar... pascalgn/automerge-action#125 😄

Same answer here: feel free to create a PR for it! 👍

@davidparsson
Copy link
Contributor Author

davidparsson commented Jan 21, 2021 •
edited
Loading

Sorry, I only looked at the open issues before posting. Thanks!

Edit: I just realized that the other issue was from another repo. 🙂

@davidparsson davidparsson mentioned this issue Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transition to running action in JS instead of Docker davidparsson/size-label-action
2 participants
@davidparsson @pascalgn