Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves ConnectorMetadata to planner session for PartiQLPlanner re-use #1323

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

RCHowell
Copy link
Member

Relevant Issues

N/A

Description

This PR replaces #1309 as we need function information to come from the catalog (ConnectorMetadata).

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]
    Yes

  • Any backward-incompatible changes? [YES/NO]

    • < If YES, why? >
    • < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in
      errors for users that are using our public APIs or the entities that have public visibility in our code-base. >
      Technically yes, but these are unreleased. This will be in a 0.14.1 patch to replace lost functionality of 0.14.0-alpha used by the transpiler.
  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
      No
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. While we know these new functions will eventually be replaced via some mechanism of the SQL Path, do you want to add an experimental tag? Non-blocking, but something to consider before release.

@RCHowell RCHowell merged commit f9b52ca into main Dec 21, 2023
3 checks passed
@RCHowell RCHowell deleted the metadata-move branch December 21, 2023 01:08
@yliuuuu yliuuuu mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants