Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle null userRoles in stream metadata fetching logic #383

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: handle null userRoles in stream metadata fetching logic #383

merged 1 commit into from
Nov 27, 2024

Conversation

praveen5959
Copy link
Contributor

  • Added a null check for userRoles in getStreamMetadata to prevent premature execution of filtering logic.
  • Updated Home component to use useEffect for conditional invocation of getStreamMetadata when userRoles is populated.

@praveen5959 praveen5959 self-assigned this Nov 26, 2024
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 0f41f2d into parseablehq:main Nov 27, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

@Koustavd18 Koustavd18 Awaiting requested review from Koustavd18

Assignees

@praveen5959 praveen5959

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveen5959 @nikhilsinhaparseable @nitisht