Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements and fixes #369

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Minor improvements and fixes #369

merged 2 commits into from
Nov 11, 2024

Conversation

pranavgoel29
Copy link
Contributor

@pranavgoel29 pranavgoel29 commented Nov 11, 2024 •
edited
Loading

  • Fixed the type check logic for getInputComponent function.
  • Removed duplicate code of HumanizeNumber present in convertToReadableScale.ts

@nitisht nitisht requested a review from praveen5959 November 11, 2024 11:22
praveen5959
praveen5959 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@praveen5959 praveen5959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nitisht nitisht merged commit 1e97253 into parseablehq:main Nov 11, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@praveen5959 praveen5959 praveen5959 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavgoel29 @praveen5959 @nitisht