Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the height mismatch for create user button #365

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Fixed the height mismatch for create user button #365

merged 1 commit into from
Nov 9, 2024

Conversation

pranavgoel29
Copy link
Contributor

@pranavgoel29 pranavgoel29 commented Nov 9, 2024 •
edited
Loading

  • Fixed height mismatch between buttons in users and roles section.

Before:
image
image

After:
image
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pranavgoel29 pranavgoel29 changed the title Fixed the height for create user button Fixed the height mismatch for create user button Nov 9, 2024
@pranavgoel29
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

nitisht added a commit to parseablehq/.github that referenced this pull request Nov 9, 2024
@nitisht
@pranavgoel29 has signed the CLA in parseablehq/console#365
e35800b
@nitisht nitisht requested a review from praveen5959 November 9, 2024 08:09
praveen5959
praveen5959 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@praveen5959 praveen5959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nitisht nitisht merged commit 5ec625f into parseablehq:main Nov 9, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@praveen5959 praveen5959 praveen5959 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavgoel29 @praveen5959 @nitisht