perf: Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` #8510

Moumouls · 2023-04-14T17:40:20Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #8421

Approach

Build blocklist once, add optimized validation process.

Supported options:

Ip ranges with CIDR
Specific ipv4 or v6
:: and ::/0 or all ipv6 match
0.0.0.0 for all ipv4
support ipv4 match padded for ipv6

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)
Add security check
Add new Parse Error codes to Parse JS SDK

parse-github-assistant · 2023-04-14T17:40:22Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-04-14T17:40:25Z

Thanks for opening this pull request!

parse-github-assistant · 2023-04-14T17:48:58Z

I will reformat the title to use the proper commit message syntax.

codecov · 2023-04-14T17:49:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7597319) 94.31% compared to head (0d92f3e) 94.32%.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #8510      +/-   ##
==========================================
+ Coverage   94.31%   94.32%   +0.01%     
==========================================
  Files         186      186              
  Lines       14798    14827      +29     
==========================================
+ Hits        13956    13985      +29     
  Misses        842      842

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Moumouls · 2023-04-14T18:01:19Z

i'll try to refactor with the native module

Moumouls · 2023-04-15T16:17:06Z

Okay, i've a native implementation with a layer of optimization to prevent performance impact.

I'll push it today !

Moumouls · 2023-04-16T10:49:15Z

Here my suggestion @mtrezza @dblythy, i hope it could help to preserve performance and reliability

mtrezza · 2023-04-16T14:54:20Z

i hope it could help to preserve performance and reliability

How could we determine the perf impact of this PR?

Moumouls · 2023-04-16T16:17:25Z

Compared to the current implemented version and also the the other pr @mtrezza

Obviously here we have a performance improvement.

Block list is computed only once
IP check on specific IP ( like localhost) is checked using the blocklist only once, then the Map cache is used
if a policy like :: or 0.0.0.0 is used it's detected only once, then only the parsing of the IP to detect V4 or V6 ran at each request

I now use it on my fork version since the current implementation has avoidable performance impact and the issue linked . I checked the code source of the current lib (ip-range), a for loop, and a parse of all provided IPS ( incoming, while list ips ) are triggered at each request.

I think I'll take some time asap, to take a look about the Flame graph of a parse server request to see if we have some performance improvement available.

I'll open a issue with my future investigation.

mtrezza · 2023-04-16T22:52:56Z

@dblythy You have looked into this issue previously, what's your opinion?

dblythy · 2023-05-16T06:44:29Z

The approach looks similar, but with the major difference that it seems to cache every valid or invalid IP.

Is the performance of Blocklist that much of an issue that caching valid IPs necessary? And in a live environment, would it be possible to perform a DOS attack by filling the cache with different IPs?

src/middlewares.js

spec/Middlewares.spec.js

mtrezza · 2023-11-17T18:02:06Z

@andreisucman The library ip-range-check that is currently used in Parse Server 6.3.0 to compare IP addresses has this limitation:

Importantly, it cannot match an IPv4 address to an IPv6 CIDR or vice versa, (IPv4-mapped IPv6 addresses notwithstanding).

So regarding your tests the value 0.0.0.0/0,::1 seems odd, because these are 2 different IP ranges in 2 different IP versions:

IPv4 0.0.0.0/0 would be ::0 in IPv6
IPv6 ::1 would be 127.0.0.1 in IPv4

For example, if your request is coming from an IPv6 address other than ::1 it will be blocked, but it will pass coming from any IPv4 address. Just want to make sure you are aware of that whether you chose these ranges intentionally.

andreisucman · 2023-11-17T18:11:34Z

Thank you @mtrezza. I didn't know that, and frankly dont quite get the significance of it. I just tried to add as many combinations as possible to effectively disable this check. But I appreciate your explanation.

mtrezza

Adding 0.0.0.0/0 range to test

spec/Middlewares.spec.js

Signed-off-by: Manuel <[email protected]>

mtrezza · 2023-11-17T18:17:24Z

I just tried to add as many combinations as possible to effectively disable this check

To allow any IPv4 and IPv6 address you would set masterKeyIPs: ['0.0.0.0/0', '::0']; that is at least for the published Parse Server versions. For this PR the lib ip-range-check is not used anymore, so it may be different. I've added tests for 0.0.0.0/0, so let's see whether the CI passes.

I think the masterKeyIPs documentation needs an amendment, because it currently only mentioned 0.0.0.0/0.

src/middlewares.js

Signed-off-by: Manuel <[email protected]>

mtrezza · 2023-11-17T18:28:10Z

It seems that this PR did not handle 0.0.0.0/0 correctly because the tests failed; I've made a change in the IP logic to account for that. @Moumouls Could you review to make sure it looks good? I think we could then just go ahead and merge the PR, since you did extensive testing with IPv4 and IPv6 ranges as well.

Moumouls · 2023-11-19T19:32:27Z

LGTM @mtrezza your adjustment is right !

mtrezza · 2023-11-19T20:15:41Z

@Moumouls I'm unsure about the PR title, because in my own testing IPv6 addresses were handled correctly, see also #8421 (comment).

Should we rename this to a perf PR, since we at least know that it adds a performance improvement thanks to the cache you've added? Or did you actually identify an issue with IPv6 addresses?

Moumouls · 2023-11-19T21:06:46Z

honestly i don't remember exactly issue encountered, but a PR was needed, feel free to adjust the PR title if you feel it do not match. @mtrezza

mtrezza · 2023-11-19T22:06:34Z

OK, so I'll change this to a perf PR, since that's the only change we currently know. @dblythy started the first PR #8501 with the description:

Currently, an ipv6 range does not seem to validate ipv4 addresses

But that could be considered a "luxury feature", since IPv6 / IPv4 address cross-matching is not even supported by the underlying IP range check library that Parse Server is currently using.

# [6.5.0-alpha.2](6.5.0-alpha.1...6.5.0-alpha.2) (2023-11-19) ### Performance Improvements * Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` ([#8510](#8510)) ([b87daba](b87daba))

parseplatformorg · 2023-11-19T22:14:35Z

🎉 This change has been released in version 6.5.0-alpha.2

# [6.5.0](6.4.0...6.5.0) (2024-03-01) ### Bug Fixes * Context not passed to Cloud Code Trigger `beforeFind` when using `Parse.Query.include` ([#8765](#8765)) ([7d32d89](7d32d89)) * Improve PostgreSQL injection detection; fixes security vulnerability [GHSA-6927-3vr9-fxf2](GHSA-6927-3vr9-fxf2) which affects Parse Server deployments using a Postgres database ([#8960](#8960)) ([a6e6549](a6e6549)) * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e)) * Security bump @babel/traverse from 7.20.5 to 7.23.2 ([#8777](#8777)) ([2d6b3d1](2d6b3d1)) * Security upgrade graphql from 16.6.0 to 16.8.1 ([#8758](#8758)) ([71dfd8a](71dfd8a)) ### Features * Add `$setOnInsert` operator to `Parse.Server.database.update` ([#8791](#8791)) ([f630a45](f630a45)) * Add compatibility for MongoDB Atlas Serverless and AWS Amazon DocumentDB with collation options `enableCollationCaseComparison`, `transformEmailToLowercase`, `transformUsernameToLowercase` ([#8805](#8805)) ([09fbeeb](09fbeeb)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Allow setting `createdAt` and `updatedAt` during `Parse.Object` creation with maintenance key ([#8696](#8696)) ([77bbfb3](77bbfb3)) * Upgrade Parse Server Push Adapter to 5.0.2 ([#8813](#8813)) ([6ef1986](6ef1986)) ### Performance Improvements * Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` ([#8510](#8510)) ([b87daba](b87daba))

parseplatformorg · 2024-03-01T16:07:01Z

🎉 This change has been released in version 6.5.0

# [7.0.0-beta.1](6.5.0-beta.1...7.0.0-beta.1) (2024-03-19) ### Bug Fixes * CacheAdapter does not connect when using a CacheAdapter with a JSON config ([#8633](#8633)) ([720d24e](720d24e)) * Conditional email verification not working in some cases if `verifyUserEmails`, `preventLoginWithUnverifiedEmail` set to functions ([#8838](#8838)) ([8e7a6b1](8e7a6b1)) * Deny request if master key is not set in Parse Server option `masterKeyIps` regardless of ACL and CLP ([#8957](#8957)) ([a7b5b38](a7b5b38)) * Docker image not published to Docker Hub on new release ([#8905](#8905)) ([a2ac8d1](a2ac8d1)) * Docker version releases by removing arm/v6 and arm/v7 support ([#8976](#8976)) ([1f62dd0](1f62dd0)) * GraphQL file upload fails in case of use of pointer or relation ([#8721](#8721)) ([1aba638](1aba638)) * Improve PostgreSQL injection detection; fixes security vulnerability [GHSA-6927-3vr9-fxf2](GHSA-6927-3vr9-fxf2) which affects Parse Server deployments using a Postgres database ([#8961](#8961)) ([cbefe77](cbefe77)) * Incomplete user object in `verifyEmail` function if both username and email are changed ([#8889](#8889)) ([1eb95ae](1eb95ae)) * Parse Server option `emailVerifyTokenReuseIfValid: true` generates new token on every email verification request ([#8885](#8885)) ([0023ce4](0023ce4)) * Parse Server option `fileExtensions` default value rejects file extensions that are less than 3 or more than 4 characters long ([#8699](#8699)) ([2760381](2760381)) * Server crashes on invalid Cloud Function or Cloud Job name; fixes security vulnerability [GHSA-6hh7-46r2-vf29](GHSA-6hh7-46r2-vf29) ([#9024](#9024)) ([9f6e342](9f6e342)) * Server crashes when receiving an array of `Parse.Pointer` in the request body ([#8784](#8784)) ([66e3603](66e3603)) * Username is `undefined` in email verification link on email change ([#8887](#8887)) ([e315c13](e315c13)) ### Features * Add `installationId` to arguments for `verifyUserEmails`, `preventLoginWithUnverifiedEmail` ([#8836](#8836)) ([a22dbe1](a22dbe1)) * Add `installationId`, `ip`, `resendRequest` to arguments passed to `verifyUserEmails` on verification email request ([#8873](#8873)) ([8adcbee](8adcbee)) * Add `Parse.User` as function parameter to Parse Server options `verifyUserEmails`, `preventLoginWithUnverifiedEmail` on login ([#8850](#8850)) ([972f630](972f630)) * Add password validation via POST request for user with unverified email using master key and option `ignoreEmailVerification` ([#8895](#8895)) ([633a9d2](633a9d2)) * Add support for MongoDB 7 ([#8761](#8761)) ([3de8494](3de8494)) * Add support for MongoDB query comment ([#8928](#8928)) ([2170962](2170962)) * Add support for Node 20, drop support for Node 14, 16 ([#8907](#8907)) ([ced4872](ced4872)) * Add support for Postgres 16 ([#8898](#8898)) ([99489b2](99489b2)) * Allow `Parse.Session.current` on expired session token instead of throwing error ([#8722](#8722)) ([f9dde4a](f9dde4a)) * Deprecation DEPPS5: Config option `allowClientClassCreation` defaults to `false` ([#8849](#8849)) ([29624e0](29624e0)) * Deprecation DEPPS6: Authentication adapters disabled by default ([#8858](#8858)) ([0cf58eb](0cf58eb)) * Deprecation DEPPS7: Remove deprecated Cloud Code file trigger syntax ([#8855](#8855)) ([4e6a375](4e6a375)) * Deprecation DEPPS8: Parse Server option `allowExpiredAuthDataToken` defaults to `false` ([#8860](#8860)) ([e29845f](e29845f)) * Deprecation DEPPS9: LiveQuery `fields` option is renamed to `keys` ([#8852](#8852)) ([38983e8](38983e8)) * Node process exits with error code 1 on uncaught exception to allow custom uncaught exception handling ([#8894](#8894)) ([70c280c](70c280c)) * Switch GraphQL server from Yoga v2 to Apollo v4 ([#8959](#8959)) ([105ae7c](105ae7c)) * Upgrade Parse Server Push Adapter to 5.0.2 ([#8813](#8813)) ([6ef1986](6ef1986)) * Upgrade to Parse JS SDK 5 ([#9022](#9022)) ([ad4aa83](ad4aa83)) ### Performance Improvements * Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` ([#8510](#8510)) ([b87daba](b87daba)) ### BREAKING CHANGES * The Parse Server option `allowClientClassCreation` defaults to `false`. ([29624e0](29624e0)) * A request using the master key will now be rejected as unauthorized if the IP from which the request originates is not set in the Parse Server option `masterKeyIps`, even if the request does not require the master key permission, for example for a public object in a public class class. ([a7b5b38](a7b5b38)) * Node process now exits with code 1 on uncaught exceptions, enabling custom handlers that were blocked by Parse Server's default behavior of re-throwing errors. This change may lead to automatic process restarts by the environment, unlike before. ([70c280c](70c280c)) * Authentication adapters are disabled by default; to use an authentication adapter it needs to be explicitly enabled in the Parse Server authentication adapter option `auth.<provider>.enabled: true` ([0cf58eb](0cf58eb)) * Parse Server option `allowExpiredAuthDataToken` defaults to `false`; a 3rd party authentication token will be validated every time the user tries to log in and the login will fail if the token has expired; the effect of this change may differ for different authentication adapters, depending on the token lifetime and the token refresh logic of the adapter ([e29845f](e29845f)) * LiveQuery `fields` option is renamed to `keys` ([38983e8](38983e8)) * Cloud Code file trigger syntax has been aligned with object trigger syntax, for example `Parse.Cloud.beforeDeleteFile'` has been changed to `Parse.Cloud.beforeDelete(Parse.File, (request) => {})'` ([4e6a375](4e6a375)) * Removes support for Node 14 and 16 ([ced4872](ced4872)) * Removes support for Postgres 11 and 12 ([99489b2](99489b2)) * The `Parse.User` passed as argument if `verifyUserEmails` is set to a function is renamed from `user` to `object` for consistency with invocations of `verifyUserEmails` on signup or login; the user object is not a plain JavaScript object anymore but an instance of `Parse.User` ([8adcbee](8adcbee)) * `Parse.Session.current()` no longer throws an error if the session token is expired, but instead returns the session token with its expiration date to allow checking its validity ([f9dde4a](f9dde4a)) * `Parse.Query` no longer supports the BSON type `code`; although this feature was never officially documented, its removal is announced as a breaking change to protect deployments where it might be in use. ([3de8494](3de8494))

parseplatformorg · 2024-03-19T18:33:31Z

🎉 This change has been released in version 7.0.0-beta.1

# [7.0.0](6.4.0...7.0.0) (2024-03-19) ### Bug Fixes * CacheAdapter does not connect when using a CacheAdapter with a JSON config ([#8633](#8633)) ([720d24e](720d24e)) * Conditional email verification not working in some cases if `verifyUserEmails`, `preventLoginWithUnverifiedEmail` set to functions ([#8838](#8838)) ([8e7a6b1](8e7a6b1)) * Context not passed to Cloud Code Trigger `beforeFind` when using `Parse.Query.include` ([#8765](#8765)) ([7d32d89](7d32d89)) * Deny request if master key is not set in Parse Server option `masterKeyIps` regardless of ACL and CLP ([#8957](#8957)) ([a7b5b38](a7b5b38)) * Docker image not published to Docker Hub on new release ([#8905](#8905)) ([a2ac8d1](a2ac8d1)) * Docker version releases by removing arm/v6 and arm/v7 support ([#8976](#8976)) ([1f62dd0](1f62dd0)) * GraphQL file upload fails in case of use of pointer or relation ([#8721](#8721)) ([1aba638](1aba638)) * Improve PostgreSQL injection detection; fixes security vulnerability [GHSA-6927-3vr9-fxf2](GHSA-6927-3vr9-fxf2) which affects Parse Server deployments using a Postgres database ([#8961](#8961)) ([cbefe77](cbefe77)) * Incomplete user object in `verifyEmail` function if both username and email are changed ([#8889](#8889)) ([1eb95ae](1eb95ae)) * Parse Server option `emailVerifyTokenReuseIfValid: true` generates new token on every email verification request ([#8885](#8885)) ([0023ce4](0023ce4)) * Parse Server option `fileExtensions` default value rejects file extensions that are less than 3 or more than 4 characters long ([#8699](#8699)) ([2760381](2760381)) * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e)) * Security bump @babel/traverse from 7.20.5 to 7.23.2 ([#8777](#8777)) ([2d6b3d1](2d6b3d1)) * Security upgrade graphql from 16.6.0 to 16.8.1 ([#8758](#8758)) ([71dfd8a](71dfd8a)) * Server crashes on invalid Cloud Function or Cloud Job name; fixes security vulnerability [GHSA-6hh7-46r2-vf29](GHSA-6hh7-46r2-vf29) ([#9024](#9024)) ([9f6e342](9f6e342)) * Server crashes when receiving an array of `Parse.Pointer` in the request body ([#8784](#8784)) ([66e3603](66e3603)) * Username is `undefined` in email verification link on email change ([#8887](#8887)) ([e315c13](e315c13)) ### Features * Add `$setOnInsert` operator to `Parse.Server.database.update` ([#8791](#8791)) ([f630a45](f630a45)) * Add `installationId` to arguments for `verifyUserEmails`, `preventLoginWithUnverifiedEmail` ([#8836](#8836)) ([a22dbe1](a22dbe1)) * Add `installationId`, `ip`, `resendRequest` to arguments passed to `verifyUserEmails` on verification email request ([#8873](#8873)) ([8adcbee](8adcbee)) * Add `Parse.User` as function parameter to Parse Server options `verifyUserEmails`, `preventLoginWithUnverifiedEmail` on login ([#8850](#8850)) ([972f630](972f630)) * Add compatibility for MongoDB Atlas Serverless and AWS Amazon DocumentDB with collation options `enableCollationCaseComparison`, `transformEmailToLowercase`, `transformUsernameToLowercase` ([#8805](#8805)) ([09fbeeb](09fbeeb)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Add password validation via POST request for user with unverified email using master key and option `ignoreEmailVerification` ([#8895](#8895)) ([633a9d2](633a9d2)) * Add support for MongoDB 7 ([#8761](#8761)) ([3de8494](3de8494)) * Add support for MongoDB query comment ([#8928](#8928)) ([2170962](2170962)) * Add support for Node 20, drop support for Node 14, 16 ([#8907](#8907)) ([ced4872](ced4872)) * Add support for Postgres 16 ([#8898](#8898)) ([99489b2](99489b2)) * Allow `Parse.Session.current` on expired session token instead of throwing error ([#8722](#8722)) ([f9dde4a](f9dde4a)) * Allow setting `createdAt` and `updatedAt` during `Parse.Object` creation with maintenance key ([#8696](#8696)) ([77bbfb3](77bbfb3)) * Deprecation DEPPS5: Config option `allowClientClassCreation` defaults to `false` ([#8849](#8849)) ([29624e0](29624e0)) * Deprecation DEPPS6: Authentication adapters disabled by default ([#8858](#8858)) ([0cf58eb](0cf58eb)) * Deprecation DEPPS7: Remove deprecated Cloud Code file trigger syntax ([#8855](#8855)) ([4e6a375](4e6a375)) * Deprecation DEPPS8: Parse Server option `allowExpiredAuthDataToken` defaults to `false` ([#8860](#8860)) ([e29845f](e29845f)) * Deprecation DEPPS9: LiveQuery `fields` option is renamed to `keys` ([#8852](#8852)) ([38983e8](38983e8)) * Node process exits with error code 1 on uncaught exception to allow custom uncaught exception handling ([#8894](#8894)) ([70c280c](70c280c)) * Switch GraphQL server from Yoga v2 to Apollo v4 ([#8959](#8959)) ([105ae7c](105ae7c)) * Upgrade Parse Server Push Adapter to 5.0.2 ([#8813](#8813)) ([6ef1986](6ef1986)) * Upgrade to Parse JS SDK 5 ([#9022](#9022)) ([ad4aa83](ad4aa83)) ### Performance Improvements * Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` ([#8510](#8510)) ([b87daba](b87daba)) ### BREAKING CHANGES * The Parse Server option `allowClientClassCreation` defaults to `false`. ([29624e0](29624e0)) * A request using the master key will now be rejected as unauthorized if the IP from which the request originates is not set in the Parse Server option `masterKeyIps`, even if the request does not require the master key permission, for example for a public object in a public class class. ([a7b5b38](a7b5b38)) * Node process now exits with code 1 on uncaught exceptions, enabling custom handlers that were blocked by Parse Server's default behavior of re-throwing errors. This change may lead to automatic process restarts by the environment, unlike before. ([70c280c](70c280c)) * Authentication adapters are disabled by default; to use an authentication adapter it needs to be explicitly enabled in the Parse Server authentication adapter option `auth.<provider>.enabled: true` ([0cf58eb](0cf58eb)) * Parse Server option `allowExpiredAuthDataToken` defaults to `false`; a 3rd party authentication token will be validated every time the user tries to log in and the login will fail if the token has expired; the effect of this change may differ for different authentication adapters, depending on the token lifetime and the token refresh logic of the adapter ([e29845f](e29845f)) * LiveQuery `fields` option is renamed to `keys` ([38983e8](38983e8)) * Cloud Code file trigger syntax has been aligned with object trigger syntax, for example `Parse.Cloud.beforeDeleteFile'` has been changed to `Parse.Cloud.beforeDelete(Parse.File, (request) => {})'` ([4e6a375](4e6a375)) * Removes support for Node 14 and 16 ([ced4872](ced4872)) * Removes support for Postgres 11 and 12 ([99489b2](99489b2)) * The `Parse.User` passed as argument if `verifyUserEmails` is set to a function is renamed from `user` to `object` for consistency with invocations of `verifyUserEmails` on signup or login; the user object is not a plain JavaScript object anymore but an instance of `Parse.User` ([8adcbee](8adcbee)) * `Parse.Session.current()` no longer throws an error if the session token is expired, but instead returns the session token with its expiration date to allow checking its validity ([f9dde4a](f9dde4a)) * `Parse.Query` no longer supports the BSON type `code`; although this feature was never officially documented, its removal is announced as a breaking change to protect deployments where it might be in use. ([3de8494](3de8494))

parseplatformorg · 2024-03-19T20:50:23Z

🎉 This change has been released in version 7.0.0

Moumouls added 2 commits April 14, 2023 15:56

feat: change ip package

2e795e6

fix: ip address handling

a13768d

parse-github-assistant bot changed the title ~~fix: ip address and optimize ip address check~~ fix: Ip address and optimize ip address check Apr 14, 2023

fix: lint

cd54e42

Moumouls changed the title ~~fix: Ip address and optimize ip address check~~ fix: masterKey and maintenanceKey Ip address handler and optimize ip address check Apr 14, 2023

parse-github-assistant bot changed the title ~~fix: masterKey and maintenanceKey Ip address handler and optimize ip address check~~ fix: MasterKey and maintenanceKey Ip address handler and optimize ip address check Apr 14, 2023

Moumouls requested review from mtrezza and dblythy April 14, 2023 17:49

Moumouls mentioned this pull request Apr 14, 2023

fix: IPv6 ranges not recognized for options masterKeyIPs, maintenanceKeyIPs #8501

Closed

2 tasks

mtrezza requested review from a team and removed request for mtrezza April 14, 2023 23:55

Moumouls added 2 commits April 16, 2023 12:26

feat: native module with cache feature

57791dd

fix: remove package

fec2e5d

Moumouls mentioned this pull request Apr 19, 2023

Parse Server option masterKeyIps not working #8512

Closed

3 tasks

Merge branch 'alpha' into moumouls/fix-ip-address

f197c07

Moumouls commented May 25, 2023

View reviewed changes

src/middlewares.js Show resolved Hide resolved

Moumouls mentioned this pull request May 25, 2023

perf: Initialize authentication adapters only once at server start #8464

Open

1 task

dblythy approved these changes May 25, 2023

View reviewed changes

mtrezza reviewed May 25, 2023

View reviewed changes

spec/Middlewares.spec.js Show resolved Hide resolved

Merge branch 'alpha' into moumouls/fix-ip-address

92aad70

Merge branch 'alpha' into moumouls/fix-ip-address

8f329e5

mtrezza requested changes Nov 17, 2023

View reviewed changes

spec/Middlewares.spec.js Show resolved Hide resolved

spec/Middlewares.spec.js Show resolved Hide resolved

mtrezza added 2 commits November 17, 2023 19:16

Update spec/Middlewares.spec.js

1286290

Signed-off-by: Manuel <[email protected]>

Update spec/Middlewares.spec.js

a634da7

Signed-off-by: Manuel <[email protected]>

mtrezza reviewed Nov 17, 2023

View reviewed changes

src/middlewares.js Outdated Show resolved Hide resolved

Update src/middlewares.js

3d378a5

Signed-off-by: Manuel <[email protected]>

Merge branch 'alpha' into moumouls/fix-ip-address

0d92f3e

mtrezza changed the title ~~fix: IPv6 ranges not recognized for options masterKeyIPs, maintenanceKeyIPs~~ perf: Improved IP validation performance for masterKeyIPs, maintenanceKeyIPs Nov 19, 2023

mtrezza merged commit b87daba into parse-community:alpha Nov 19, 2023
23 of 28 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Nov 19, 2023

parseplatformorg added the state:released-release-6.x.x label Mar 1, 2024

parseplatformorg added the state:released-beta Released as beta version label Mar 19, 2024

parseplatformorg added the state:released Released as stable version label Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` #8510

perf: Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` #8510

Moumouls commented Apr 14, 2023 •

edited

Loading

parse-github-assistant bot commented Apr 14, 2023

parse-github-assistant bot commented Apr 14, 2023 •

edited

Loading

parse-github-assistant bot commented Apr 14, 2023

codecov bot commented Apr 14, 2023 •

edited

Loading

Moumouls commented Apr 14, 2023

Moumouls commented Apr 15, 2023

Moumouls commented Apr 16, 2023

mtrezza commented Apr 16, 2023

Moumouls commented Apr 16, 2023

mtrezza commented Apr 16, 2023

dblythy commented May 16, 2023

mtrezza commented Nov 17, 2023 •

edited

Loading

andreisucman commented Nov 17, 2023

mtrezza left a comment

mtrezza commented Nov 17, 2023 •

edited

Loading

mtrezza commented Nov 17, 2023

Moumouls commented Nov 19, 2023

mtrezza commented Nov 19, 2023

Moumouls commented Nov 19, 2023

mtrezza commented Nov 19, 2023 •

edited

Loading

parseplatformorg commented Nov 19, 2023

parseplatformorg commented Mar 1, 2024

parseplatformorg commented Mar 19, 2024

parseplatformorg commented Mar 19, 2024

perf: Improved IP validation performance for masterKeyIPs, maintenanceKeyIPs #8510

perf: Improved IP validation performance for masterKeyIPs, maintenanceKeyIPs #8510

Conversation

Moumouls commented Apr 14, 2023 • edited Loading

Pull Request

Issue

Approach

Tasks

parse-github-assistant bot commented Apr 14, 2023

parse-github-assistant bot commented Apr 14, 2023 • edited Loading

Thanks for opening this pull request!

parse-github-assistant bot commented Apr 14, 2023

codecov bot commented Apr 14, 2023 • edited Loading

Codecov Report

Moumouls commented Apr 14, 2023

Moumouls commented Apr 15, 2023

Moumouls commented Apr 16, 2023

mtrezza commented Apr 16, 2023

Moumouls commented Apr 16, 2023

mtrezza commented Apr 16, 2023

dblythy commented May 16, 2023

mtrezza commented Nov 17, 2023 • edited Loading

andreisucman commented Nov 17, 2023

mtrezza left a comment

Choose a reason for hiding this comment

mtrezza commented Nov 17, 2023 • edited Loading

mtrezza commented Nov 17, 2023

Moumouls commented Nov 19, 2023

mtrezza commented Nov 19, 2023

Moumouls commented Nov 19, 2023

mtrezza commented Nov 19, 2023 • edited Loading

parseplatformorg commented Nov 19, 2023

parseplatformorg commented Mar 1, 2024

parseplatformorg commented Mar 19, 2024

parseplatformorg commented Mar 19, 2024

perf: Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` #8510

perf: Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` #8510

Moumouls commented Apr 14, 2023 •

edited

Loading

parse-github-assistant bot commented Apr 14, 2023 •

edited

Loading

codecov bot commented Apr 14, 2023 •

edited

Loading

mtrezza commented Nov 17, 2023 •

edited

Loading

mtrezza commented Nov 17, 2023 •

edited

Loading

mtrezza commented Nov 19, 2023 •

edited

Loading