Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax errors aren't logged correctly in LiveQuery triggers #7836

Closed
4 tasks done
dblythy opened this issue Mar 10, 2022 · 1 comment · Fixed by #7837
Closed
4 tasks done

Syntax errors aren't logged correctly in LiveQuery triggers #7836

dblythy opened this issue Mar 10, 2022 · 1 comment · Fixed by #7837
Labels
type:feature New feature or improvement of existing feature

Comments

@dblythy
Copy link
Member

dblythy commented Mar 10, 2022

New Issue Checklist

Issue Description

When a syntax error is recorded in either a beforeConnect, beforeSubscribe, or afterLiveQueryEvent trigger, the error is logged without any useful infomation to help diagnose.

Steps to reproduce

Create a LQ trigger with a JS error.

Actual Outcome

Failed running beforeConnect for session undefined with:
     Error: {}

Expected Outcome

Failed running beforeConnect for session undefined with:
     Error: foo is undefined

Environment

Server

  • Parse Server version: master
  • Operating system: macos
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

  • System (MongoDB or Postgres): mongo
  • Database version: 5
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): local

Client

  • SDK (iOS, Android, JavaScript, PHP, Unity, etc): JS
  • SDK version: master

Logs

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Mar 10, 2022
@mtrezza mtrezza linked a pull request Mar 10, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants