Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combability with node 16 #7738

Closed
hellow554 opened this issue Dec 8, 2021 · 5 comments · Fixed by #7739
Closed

Combability with node 16 #7738

hellow554 opened this issue Dec 8, 2021 · 5 comments · Fixed by #7739
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@hellow554
Copy link

The doc states that parse should be compatible with node.js 16:

Version Latest Version End-of-Life Compatible
Node.js 12 12.22.7 April 2022 ✅ Yes
Node.js 14 14.18.1 April 2023 ✅ Yes
Node.js 16 16.13.0 April 2024 ✅ Yes
Node.js 17 17.x June 2022 ❌ Not tested

the source code however says otherwise:

parse-server/package.json

Line 134 in ac789c8

"node": ">=12.20.0 <16"

which results in:

# yarn global add [email protected]
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=12.20.0 <16". Got "16.13.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.
@hellow554 hellow554 changed the title Ccombability with node 16 Combability with node 16 Dec 8, 2021
@parse-github-assistant
Copy link

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@hellow554
Copy link
Author

This should be fixed by #7710 :)

@mtrezza mtrezza mentioned this issue Dec 8, 2021
Merged
4 tasks
@mtrezza
Copy link
Member

mtrezza commented Dec 8, 2021

I've opened #7739 so you don't have to wait for #7710 to get merged.

@mtrezza mtrezza added severity:medium type:bug Impaired feature or lacking behavior that is likely assumed labels Dec 8, 2021
@mtrezza mtrezza linked a pull request Dec 8, 2021 that will close this issue
fix: node engine compatibility did not include node 16 #7739
Merged
4 tasks
mtrezza referenced this issue Dec 8, 2021
@marvinroger
feat: add support for Node 16 (#7707)
45cc58c 
BREAKING CHANGE: Removes official Node 15 support which has reached it end-of-life date.
@hellow554
Copy link
Author

Thank you for the fix and the tag!

@mtrezza
Copy link
Member

mtrezza commented Dec 8, 2021

Sure! Thanks for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: node engine compatibility did not include node 16 parse-community/parse-server
2 participants
@hellow554 @mtrezza