-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bcrypt binary incompatibility #6891
fix bcrypt binary incompatibility #6891
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6891 +/- ##
==========================================
+ Coverage 93.73% 93.80% +0.06%
==========================================
Files 169 169
Lines 12220 12220
==========================================
+ Hits 11455 11463 +8
+ Misses 765 757 -8
Continue to review full report at Codecov.
|
@dplewis Aren't packages automatically upgraded by the bots on Github? I am surprised this packages was still on an old version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it works for optionalDependencies
for the bot
Is this already released? I'm using "parse-server": "^4.3.0" and I'm still having this issue. #6837 |
The fix has not been released yet. Parse Server 4.3.0 was released on July 19, this PR was merged in September. You can either use the master branch or fork the repository and manually add the fix to release 4.3.0 to deploy Parse Server with this fix included. |
got it. Do you have a release date? |
Parse Server has no fixed release cycles, but that is something we will look into to provide more transparency and predictably. However, in case this would be a first for you, it may be beneficial to figure out how to deploy a forked version of Parse Server in which you add that fix. It is quite easy and once you have done it, you never will have to wait for an official release anymore, so it may be worth trying. |
Thanks!! I did what you said and It worked awesome. I'm a forking man now |
closes #6837