Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bcrypt binary incompatibility #6891

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 1, 2020

closes #6837

@mtrezza mtrezza requested a review from dplewis September 1, 2020 11:53
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #6891 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6891      +/-   ##
==========================================
+ Coverage   93.73%   93.80%   +0.06%     
==========================================
  Files         169      169              
  Lines       12220    12220              
==========================================
+ Hits        11455    11463       +8     
+ Misses        765      757       -8     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoTransform.js 88.82% <0.00%> (+0.14%) ⬆️
src/Controllers/DatabaseController.js 95.33% <0.00%> (+0.15%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.92% <0.00%> (+0.88%) ⬆️
src/ParseServerRESTController.js 98.18% <0.00%> (+1.81%) ⬆️
src/batch.js 91.83% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a92cb7...567c8f9. Read the comment docs.

@mtrezza
Copy link
Member Author

mtrezza commented Sep 1, 2020

@dplewis Aren't packages automatically upgraded by the bots on Github? I am surprised this packages was still on an old version.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it works for optionalDependencies for the bot

@dplewis dplewis merged commit d500557 into parse-community:master Sep 1, 2020
@arlanding
Copy link

Is this already released? I'm using "parse-server": "^4.3.0" and I'm still having this issue. #6837

@mtrezza
Copy link
Member Author

mtrezza commented Oct 29, 2020

The fix has not been released yet.

Parse Server 4.3.0 was released on July 19, this PR was merged in September. You can either use the master branch or fork the repository and manually add the fix to release 4.3.0 to deploy Parse Server with this fix included.

@arlanding
Copy link

got it. Do you have a release date?

@mtrezza
Copy link
Member Author

mtrezza commented Oct 29, 2020

Parse Server has no fixed release cycles, but that is something we will look into to provide more transparency and predictably.

However, in case this would be a first for you, it may be beneficial to figure out how to deploy a forked version of Parse Server in which you add that fix. It is quite easy and once you have done it, you never will have to wait for an official release anymore, so it may be worth trying.

@arlanding
Copy link

Thanks!! I did what you said and It worked awesome. I'm a forking man now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol not found in @node-rs/bcrypt when upgrade from 4.2.0 to 4.3.0
3 participants