fix: Unrestrict fileSubDirectory
#75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
obermillerk
changed the title
fileSubDirectoryfileSubDirectory
obermillerk
changed the title
fileSubDirectoryfileSubDirectory
mtrezza
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Could you take a look at the failing test? We need to ensure this is not a breaking change; could you keep the existing test instead of rewriting it and add a new test for the new use case you are introducing?
This PR title indicates a bug fix, but it seems to be this is a feature request, correct? If so, please change the title to feat: <new feature description>.
|
fix vs feat kind of depends on your perspective (presently it doesn't work the way the docs indicate it should even if the behavior is intentional), but I can make it a feature if you prefer. I'll look into the tests. |
|
If it's not working according to docs, then I'd agree that it's a fix. Thanks for looking into the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #50
Could rename
filesSubDirectorytofilesDirectoryperhaps?