Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting authResponse is not supported #726

Closed
jsdevjournal opened this issue Feb 5, 2019 · 9 comments
Closed

Setting authResponse is not supported #726

jsdevjournal opened this issue Feb 5, 2019 · 9 comments

Comments

@jsdevjournal
Copy link
Contributor

Hi, I wonder if anyone else face this issue when try to login with facebook?
Also happens when trying to login with email/password for facebook authenticated users.

The /login request was succeed. It returns status code 200 with users data.
However, the javascript sdk rejects the request and returns an error. Setting authResponse is not supported

I have tested in js version 2.0.2.

@jsdevjournal
Copy link
Contributor Author

For more information, I have comment out Parse.FacebookUtils.init and the problem is gone.

@jsdevjournal
Copy link
Contributor Author

jsdevjournal commented Feb 5, 2019

This is weird but problem seems to be a conflict between Parse.FacebookUtils and Facebook official sdk.

Please see this line of code from unminified facebook js sdk.

https://github.com/nfriedly/facebook-js-sdk/blob/cd1f144d334e7e200b2ba6c7ca0e51636063a9b6/debug.js#L14268

It checks for authResponse and returns an error.

Please also look at this line of code of this project.

newOptions.authResponse = authResponse;

authResponse is assigned to an option intentionally.


I solve this by change the facebook sdk url from //connect.facebook.net/en_US/sdk.js to //connect.facebook.net/en_US/all.js

The different is sdk.js and all.js

So maybe somebody can look into this issue, Thanks~

@schurch
Copy link

schurch commented Feb 6, 2019

I'm also seeing this issue.

@flovilmart
Copy link
Contributor

Can you open a pull request please? I am not sure where this code is located

Sent with GitHawk

@Jauny
Copy link

Jauny commented Feb 12, 2019

Same for me, started to see this, our facebook login is broken because of this.

thanks for the PR @durunvo !

@flovilmart what can I do to help push this through? This issue is preventing us from releasing to prod :)

@flovilmart
Copy link
Contributor

The PR don’t add any test and the resolution doesn’t match with what was described (changing the SDK URL). So That’s what I’d least expect. Cc @dplewis, can you then review, merge and release please?

Sent with GitHawk

@RadianSmile
Copy link

I solve this by change the facebook sdk url from //connect.facebook.net/en_US/sdk.js to //connect.facebook.net/en_US/all.js

this works for me

@dplewis
Copy link
Member

dplewis commented Mar 26, 2019

Closing via #728

@dplewis dplewis closed this as completed Mar 26, 2019
@drewrwilson
Copy link

thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants