-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add transaction to save and destroy on Parse.Object
#2265
feat: Add transaction to save and destroy on Parse.Object
#2265
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2265 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6392 +206
Branches 1499 1520 +21
==========================================
+ Hits 6186 6392 +206 ☔ View full report in Codecov by Sentry. |
@mtrezza Could you please check and review the changes when you have a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; let's see if someone from the JS team has any feedback before we merge. Btw, would you be interested to get team to get notified when someone is requesting feedback on their PR?
Is this a fix or a feature? From the issue description it looks more like a new feature?
Parse.Object
Thanks for the feedback! I agree, this is more of a feature than a fix. |
You'd just be added to the review team here on GitHub. When someone submits a PR and the PR is ready for review, then you'd get a notification and if you have some time you can look over it and provide feedback. No obligation though. |
Parse.Object
Parse.Object
Sure, thanks for the trust! I'd be happy to help as much as I can. |
# [5.3.0-alpha.4](5.3.0-alpha.3...5.3.0-alpha.4) (2024-10-14) ### Features * Add transaction to save and destroy on `Parse.Object` ([#2265](#2265)) ([2b55bdf](2b55bdf))
🎉 This change has been released in version 5.3.0-alpha.4 |
Very nice! Been waiting for this feature for quite some time so I'll give it a try later 😃 |
Pull Request
Issue
This pull request addresses issues related to performing batch transactions.
Closes: #922
Approach
transaction
option to thesave
anddestroy
methods in theParseObject
class.Tasks
transaction
option tosave
anddestroy
in theParseObject
class.