Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change bins in classifier nodes #326

Open
masterfelu opened this issue Aug 16, 2024 · 2 comments
Open

change bins in classifier nodes #326

masterfelu opened this issue Aug 16, 2024 · 2 comments

Comments

@masterfelu
Copy link

Hello.

Thanks a lot for making this public! It is a wonderful repo.
I was wondering if it is possible to change the number of bins for a classifier node when using viz_model.view(). It would look nice with histtype step for large datasets.

Thanks a lot again!

@tlapusan
Copy link
Collaborator

Hi @masterfelu, thanks for the nice words :)

Could you give us some screenshots with your situation?
I'm in vacation right now, from what I remember, the number of bins is dinamicaly generated. Have to look in the source code

@masterfelu
Copy link
Author

masterfelu commented Aug 17, 2024

Sure! Thanks for taking a look at it during vacation.

image

We can see that for some nodes; it might look better if there were more bins, for example, the last row's last node. Bins in the range 50 to 100 would look fine in my case since there are more than 100k data points. It is just a matter of convenience since I might be inspecting multiple trees by eyeballing.

I took a look at your source, and it seems to be hard-coded as NUM_BINS. It seems to be dynamic, but the limit is 20.

What I imagined a node would look like is the one below(ignore the texts in the plot).

image

It is of histtype step and the bins are 50.

This is mostly my fault since I am not limiting my feature ranges properly. It is nice to know it can be improved by just using your tool!

Thanks for your time again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants