Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hackney to fix sslv3 reference on OTP 23 #225

Merged
merged 1 commit into from
May 26, 2020

Conversation

fhunleth
Copy link
Contributor

This fixes the following error when using OTP 23:

 ** (Protocol.UndefinedError) protocol String.Chars not implemented for {:options, {:sslv3, {:versions, [:"tlsv1.2", :
        (elixir 1.10.3) lib/string/chars.ex:3: String.Chars.impl_for!/1
        (elixir 1.10.3) lib/string/chars.ex:22: String.Chars.to_string/1
        lib/excoveralls/poster.ex:58: ExCoveralls.Poster.send_file/2
        lib/excoveralls/poster.ex:13: ExCoveralls.Poster.execute/2
        (mix 1.10.3) lib/mix/tasks/test.ex:484: Mix.Tasks.Test.do_run/3
        (mix 1.10.3) lib/mix/task.ex:330: Mix.Task.run_task/3
        lib/mix/tasks.ex:54: Mix.Tasks.Coveralls.do_run/2
        (mix 1.10.3) lib/mix/task.ex:330: Mix.Task.run_task/3
        (mix 1.10.3) lib/mix/cli.ex:82: Mix.CLI.run_task/2
        (elixir 1.10.3) lib/code.ex:926: Code.require_file/2

The error is due to hackney previously adding sslv3 to the ssl_options
when they aren't specified and OTP 23 removing support for sslv3.
Hackney 1.16.0 fixes this.

This fixes the following error when using OTP 23:

```
 ** (Protocol.UndefinedError) protocol String.Chars not implemented for {:options, {:sslv3, {:versions, [:"tlsv1.2", :
        (elixir 1.10.3) lib/string/chars.ex:3: String.Chars.impl_for!/1
        (elixir 1.10.3) lib/string/chars.ex:22: String.Chars.to_string/1
        lib/excoveralls/poster.ex:58: ExCoveralls.Poster.send_file/2
        lib/excoveralls/poster.ex:13: ExCoveralls.Poster.execute/2
        (mix 1.10.3) lib/mix/tasks/test.ex:484: Mix.Tasks.Test.do_run/3
        (mix 1.10.3) lib/mix/task.ex:330: Mix.Task.run_task/3
        lib/mix/tasks.ex:54: Mix.Tasks.Coveralls.do_run/2
        (mix 1.10.3) lib/mix/task.ex:330: Mix.Task.run_task/3
        (mix 1.10.3) lib/mix/cli.ex:82: Mix.CLI.run_task/2
        (elixir 1.10.3) lib/code.ex:926: Code.require_file/2
```

The error is due to hackney previously adding sslv3 to the ssl_options
when they aren't specified and OTP 23 removing support for sslv3.
Hackney 1.16.0 fixes this.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.823% when pulling 23b503b on fhunleth:update-hackney into 6332f40 on parroty:master.

@parroty parroty merged commit fe77273 into parroty:master May 26, 2020
@parroty
Copy link
Owner

parroty commented May 26, 2020

Thanks!

@fhunleth fhunleth deleted the update-hackney branch May 26, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants